From 590e92eea4dca8dd20d72a5bd4775bb6f31f99ba Mon Sep 17 00:00:00 2001
From: m5r <mokht@rmi.al>
Date: Sun, 26 Jun 2022 13:52:36 +0200
Subject: [PATCH] add todos and change wording

---
 app/features/public-area/components/cta-form.tsx         | 1 +
 .../settings/components/phone/twilio-connect.tsx         | 9 ++++++++-
 app/routes/webhook/call.ts                               | 2 +-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/app/features/public-area/components/cta-form.tsx b/app/features/public-area/components/cta-form.tsx
index 36d5a77..030c31d 100644
--- a/app/features/public-area/components/cta-form.tsx
+++ b/app/features/public-area/components/cta-form.tsx
@@ -1,6 +1,7 @@
 import { useState } from "react";
 
 export default function CTAForm() {
+	// TODO
 	const [{ isSubmitted }, setState] = useState({ isSubmitted: false });
 	const onSubmit = () => setState({ isSubmitted: true });
 
diff --git a/app/features/settings/components/phone/twilio-connect.tsx b/app/features/settings/components/phone/twilio-connect.tsx
index e9c71eb..2ee76e1 100644
--- a/app/features/settings/components/phone/twilio-connect.tsx
+++ b/app/features/settings/components/phone/twilio-connect.tsx
@@ -40,7 +40,14 @@ export default function TwilioConnect() {
 						<IoHelpCircle className="w-6 h-6 text-primary-700" />
 					</button>
 					<article className="mb-6">
-						Shellphone needs some informations about your Twilio account to securely use your phone numbers.
+						<p>
+							To connect your Twilio Account you will need to provide us your Twilio account SID and auth
+							token.
+						</p>
+						<p>
+							Both values can be found on your{" "}
+							<a href="https://www.twilio.com/user/account/settings">Twilio account page</a>.
+						</p>
 					</article>
 
 					{twilio !== null ? (
diff --git a/app/routes/webhook/call.ts b/app/routes/webhook/call.ts
index 0222560..32f131f 100644
--- a/app/routes/webhook/call.ts
+++ b/app/routes/webhook/call.ts
@@ -190,7 +190,7 @@ async function handleOutgoingCall(formData: unknown, twilioSignature: string) {
 			answerOnBridge: true,
 			callerId: phoneNumber!.number,
 		});
-		dial.number(recipient);
+		dial.number(recipient); // TODO: si le device n'est pas registered => call failed *shrug*
 		console.log("twiml voiceResponse", voiceResponse.toString());
 
 		return new Response(voiceResponse.toString(), { headers: { "Content-Type": "text/xml" } });